Skip to content

fix(@angular/ssr): decode x-forwarded-prefix before validation #32904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alan-agius4 wants to merge 2 commits into from
Closed

fix(@angular/ssr): decode x-forwarded-prefix before validation #32904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f100f2b
fix(@angular/ssr): decode x-forwarded-prefix before validation
alan-agius4 Mar 31, 2026
642988a
fixup! fix(@angular/ssr): decode x-forwarded-prefix before validation
alan-agius4 Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix(@angular/ssr): decode x-forwarded-prefix before validation
  • Loading branch information
@alan-agius4
alan-agius4 committed Mar 31, 2026
commit 642988a4a7f2ff703e686e757ddb86046935725a
2 changes: 1 addition & 1 deletion packages/angular/ssr/src/utils/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ function validateHeaders(request: Request): void {
if (xForwardedPrefix) {
let xForwardedPrefixDecoded: string;
try {
xForwardedPrefixDecoded = decodeURIComponent(xForwardedPrefix);
xForwardedPrefixDecoded = decodeURIComponent(xForwardedPrefix).trim();
} catch (e) {
throw new Error(
'Header "x-forwarded-prefix" contains an invalid value and cannot be decoded.',
Expand Down
2 changes: 2 additions & 0 deletions packages/angular/ssr/test/utils/validation_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,8 @@ describe('Validation Utils', () => {
'/foo/..\\bar',
'.',
'..',
'%2e',
'%2e%2e/foo',
];

for (const prefix of inputs) {
Expand Down
Loading