Skip to content

fix(@schematics/angular): preserve the workspace build version during migration #32875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raashish1601 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(@schematics/angular): preserve the workspace build version during migration #32875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4493d78
fix(@schematics/angular): preserve workspace build version
raashish1601 Mar 27, 2026
60392dd
fix(@schematics/angular): keep existing build versions
raashish1601 Mar 27, 2026
c82410d
fix(@schematics/angular): use angular build fallback version
raashish1601 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(@schematics/angular): keep existing build versions
  • Loading branch information
@raashish1601
raashish1601 committed Mar 27, 2026
commit 60392dd84e863bc09754a34efccca53a82d4173c
12 changes: 6 additions & 6 deletions packages/schematics/angular/migrations/use-application-builder/migration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ import {
externalSchematic,
} from '@angular-devkit/schematics';
import { dirname, join } from 'node:path/posix';
import { getPackageJsonDependency } from '../../utility/dependencies';
import {
DependencyType,
ExistingBehavior,
addDependency,
getDependency,
removeDependency,
} from '../../utility/dependency';
import { JSONFile } from '../../utility/json-file';
Expand Down Expand Up @@ -271,13 +271,13 @@ function updateProjects(tree: Tree, context: SchematicContext) {
}

// Add direct @angular/build dependencies and remove @angular-devkit/build-angular
const buildDependency =
getPackageJsonDependency(tree, '@angular-devkit/build-angular') ??
getPackageJsonDependency(tree, '@angular/build');
const buildAngularVersion =
getDependency(tree, '@angular-devkit/build-angular')?.version ??
latestVersions.DevkitBuildAngular;
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT

Suggested change
latestVersions.DevkitBuildAngular;
latestVersions.AngularBuild;

rules.push(
addDependency('@angular/build', buildDependency?.version ?? latestVersions.AngularBuild, {
addDependency('@angular/build', buildAngularVersion, {
type: DependencyType.Dev,
existing: ExistingBehavior.Replace,
existing: ExistingBehavior.Skip,
}),
removeDependency('@angular-devkit/build-angular'),
);
Expand Down
18 changes: 18 additions & 0 deletions packages/schematics/angular/migrations/use-application-builder/migration_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,24 @@ describe(`Migration to use the application builder`, () => {
expect(devDependencies['@angular-devkit/build-angular']).toBeUndefined();
});

it('should preserve an existing "@angular/build" version when migrating', async () => {
tree.overwrite(
'/package.json',
JSON.stringify({
devDependencies: {
'@angular-devkit/build-angular': '~18.2.20',
'@angular/build': '~18.2.10',
},
}),
);

const newTree = await schematicRunner.runSchematic(schematicName, {}, tree);

const { devDependencies } = JSON.parse(newTree.readContent('/package.json'));
expect(devDependencies['@angular/build']).toBe('~18.2.10');
expect(devDependencies['@angular-devkit/build-angular']).toBeUndefined();
});

it('it should not add esModuleInterop and moduleResolution when module is preserve', async () => {
tree.overwrite(
'tsconfig.json',
Expand Down
Loading