Skip to content

fix(@angular/build): simplify SSL handling for ng serve with SSR #31722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alan-agius4 merged 5 commits into from
Nov 8, 2025
Merged

fix(@angular/build): simplify SSL handling for ng serve with SSR #31722

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b6c271
fix(@angular/build): simplify SSL handling for with SSR
alan-agius4 Nov 7, 2025
f2a4b3c
fixup! fix(@angular/build): simplify SSL handling for with SSR
alan-agius4 Nov 7, 2025
b5b720d
fixup! fix(@angular/build): simplify SSL handling for with SSR
alan-agius4 Nov 7, 2025
6a5fdad
fixup! fix(@angular/build): simplify SSL handling for with SSR
alan-agius4 Nov 7, 2025
31a40e2
fixup! fix(@angular/build): simplify SSL handling for with SSR
alan-agius4 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix(@angular/build): simplify SSL handling for with SSR
  • Loading branch information
@alan-agius4
alan-agius4 committed Nov 7, 2025
commit 31a40e2d3d8beaadd0fdf04e6eac155993478ee0
5 changes: 3 additions & 2 deletions packages/angular/build/src/tools/vite/plugins/ssr-ssl-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,18 @@ export function createAngularServerSideSSLPlugin(): Plugin {
async configureServer({ config, httpServer }) {
const {
ssr,
server: { https: cert },
server: { https },
} = config;

if (!ssr || !cert) {
if (!ssr || !https?.cert) {
return;
}

// TODO(alanagius): Replace `undici` with `tls.setDefaultCACertificates` once we only support Node.js 22.18.0+ and 24.5.0+.
// See: https://nodejs.org/api/tls.html#tlssetdefaultcacertificatescerts
const { getGlobalDispatcher, setGlobalDispatcher, Agent } = await import('undici');
const originalDispatcher = getGlobalDispatcher();
const { cert } = https;
const certificates = Array.isArray(cert) ? cert : [cert];

setGlobalDispatcher(
Expand Down