Skip to content

feat(@angular/cli): allow using Deno as package manager #30948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csvn wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(@angular/cli): allow using Deno as package manager #30948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2251d82
feat(@angular/cli): allow using Deno as package manager
csvn Aug 18, 2025
38470cb
ci: add CI for deno package manager
alan-agius4 Aug 19, 2025
8504d27
fix(@angular/cli): update deno version
csvn Nov 20, 2025
f26427e
fix(@angular/cli): address lint formatting issues
csvn Nov 20, 2025
aa6cb3f
fixup! feat(@angular/cli): allow using Deno as package manager
alan-agius4 Dec 4, 2025
c697552
fixup! feat(@angular/cli): allow using Deno as package manager
csvn Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(@angular/cli): update deno version
  • Loading branch information
@csvn
csvn committed Nov 20, 2025
commit 8504d27102b0e3c32d1615d3ff87fc0d2f637b88
2 changes: 1 addition & 1 deletion packages/angular/cli/src/utilities/package-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ export class PackageManagerUtils {
}).trim();

if (name === PackageManager.Deno) {
// Deno CLI outputs "deno 2.4.4"
// Deno CLI outputs "deno 2.5.6"
return version.replace('deno ', '');
Copy link
Copy Markdown
Collaborator

@alan-agius4 alan-agius4 Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have changed.

deno --version
deno 2.5.6 (stable, release, x86_64-unknown-linux-gnu)
v8 14.0.365.5-rusty
typescript 5.9.2

Copy link
Copy Markdown
Contributor Author

@csvn csvn Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... maybe this differs by platform? For me on Windows I get a shorter version output with -v, and a more verbose one with --version. That's why I added the ternary to switch to the -v flag on L224:

angular-cli/packages/angular/cli/src/utilities/package-manager.ts

Line 224 in 38470cb

const versionArg = name !== PackageManager.Deno ? '--version' : '-v'; 

> PS C:\Users\csvn\dev\angular-cli> deno --version
deno 2.5.6 (stable, release, x86_64-pc-windows-msvc)
v8 14.0.365.5-rusty
typescript 5.9.2

> PS C:\Users\csvn\dev\angular-cli> deno -v
deno 2.5.6

I used the shorter one (-v) to simplify parsing the version correctly. But I could perhaps change to a regex to extract the version when using --version? Something along the lines of /deno (?<version>\S{5,})/.

Copy link
Copy Markdown
Contributor Author

@csvn csvn Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked into the E2E test errors yet, so I don't know why those fail. But I know it works to create a new Angular project with Deno like this:

> PS C:\Users\ChristianSvensson\Dev\_personal> deno run -Ar npm:@angular/cli new test-project --skip-install --test-runner karma
✔ Which stylesheet system would you like to use? CSS             [ https://developer.mozilla.org/docs/Web/CSS]
✔ Do you want to enable Server-Side Rendering (SSR) and Static Site Generation (SSG/Prerendering)? No
✔ Which AI tools do you want to configure with Angular best practices? https://angular.dev/ai/develop-with-ai None
CREATE test-project/angular.json (2166 bytes)
...[snip]...
CREATE test-project/public/favicon.ico (15086 bytes)
    Successfully initialized git.

> PS C:\Users\ChristianSvensson\Dev\_personal>

}

Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/setup/100-global-cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const PACKAGE_MANAGER_VERSION = {
'yarn': '1.22.22',
'pnpm': '10.17.1',
'bun': '1.3.2',
'deno': '2.4.4',
'deno': '2.5.6',
};

export default async function() {
Expand Down