Skip to content

fix(deps): explicitely add portfinder - #2831

Merged
hansl merged 2 commits into
angular:masterfrom
filipesilva:add-portfinder
Nov 9, 2016
Merged

hansl merged 2 commits into
angular:masterfrom
filipesilva:add-portfinder

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

This PR explicitely adds portfinder as a dependency.

We're using portfinder in the serve command but getting it transitively as a ember-cli dependency.

Fix #2769

This PR explicitely adds portfinder as a dependency.

We're using portfinder in the serve command but getting it transitively as a ember-cli dependency.

Fix angular#2755
Fix angular#2769
@hansl

hansl commented Nov 9, 2016

Copy link
Copy Markdown
Contributor

LGTM.

@hansl
hansl merged commit 2d8f162 into angular:master Nov 9, 2016
@filipesilva
filipesilva deleted the add-portfinder branch November 9, 2016 10:14
MRHarrison pushed a commit to MRHarrison/angular-cli that referenced this pull request Feb 9, 2017
This PR explicitely adds portfinder as a dependency.

We're using portfinder in the serve command but getting it transitively as a ember-cli dependency.

Fix angular#2755
Fix angular#2769
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PortFinder crashes with unused adapter

3 participants