feat(@angular-devkit/build-optimizer): scrub ɵsetClassMetadata and ɵɵsetNgModuleScope calls#15664
Conversation
|
Note to reviewers: |
6ad8f66 to
b3cb029
Compare
b3cb029 to
d480bda
Compare
IgorMinar
left a comment
There was a problem hiding this comment.
the rest looks great! thank for quick turnaround.
| const exprStmt = node as ts.ExpressionStatement; | ||
| if (isDecoratorAssignmentExpression(exprStmt)) { | ||
| // Do checks that don't need the typechecker first and bail early. | ||
| if (isCtorParamsAssignmentExpression(exprStmt) |
There was a problem hiding this comment.
consider swapping the two checks to optimize for the build speed of Ivy code over the legacy ctorParam format.
…setNgModuleScope calls
d480bda to
8858dd2
Compare
|
@vikerman suggested adding a e2e with lazy loaded chunk and track it on the size tracker to prevent regressions. |
|
@filipesilva sgtm. I was going to add a similar e2e test to the angular repo as well. will this e2e test you intend to write be in the cli repo? I assume so. I guess it doesn't hurt to have this one in two places, but if you were to add the test just to the angular/angular repo then that would be fine as well. |
|
For comparison, this is a new project with routing, before and after having a lazy route, and before this PR:
|
|
Note to caretaker: it is expected that the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.