fix(@angular/cli): use correct schematic defaults considering workspace#15041
Merged
Conversation
833b495 to
a1d3501
Compare
a1d3501 to
6edcb94
Compare
ffbef51 to
e67470b
Compare
alan-agius4
reviewed
Jul 12, 2019
alan-agius4
reviewed
Jul 12, 2019
alan-agius4
reviewed
Jul 12, 2019
clydin
requested changes
Jul 16, 2019
Fix angular#14986 This PR includes some refactoring to simplify the interaction of the `NodeWorkflow` and the `BaseWorkflow` with the registry. We were registering redundant `addPostTransform`s. Some of them in the constructor of the `BaseWorkflow`, which did not allow us to intercept `addUndefinedDefaults`. Additionally, we were setting the `validateOptionsWithSchema` transform multiple times unnecessarily. An issue left to fix is support for the `--project` option in schematic commands. Currently, `getProjectName` does not know about this option, since `createWorkflow` does not know how to parse the command line arguments. The parsing logic is implemented partially by the concrete implementation of the `SchematicCommand` template method.
b89fad9 to
a21d38a
Compare
clydin
reviewed
Jul 16, 2019
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
| // tslint:disable:no-implicit-dependencies | ||
| import { schema } from '@angular-devkit/core'; |
clydin
approved these changes
Jul 16, 2019
Member
clydin
left a comment
There was a problem hiding this comment.
I think this should also fix a variety of other open issues regarding defaults not being used for some schematics.
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 3, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 5, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 5, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 5, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 5, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
brandonroberts
added a commit
to brandonroberts/nx
that referenced
this pull request
Sep 6, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
vsavkin
pushed a commit
to nrwl/nx
that referenced
this pull request
Sep 7, 2019
Incorporates fix from angular/angular-cli#15041 which changed the behavior of registering schematic defaults
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14986
This PR includes some refactoring to simplify the interaction of the
NodeWorkflowand theBaseWorkflowwith the registry.We were registering redundant
addPostTransforms. Some of them in the constructor of theBaseWorkflow, which did not allow us to interceptaddUndefinedDefaults.Additionally, we were setting the
validateOptionsWithSchematransform multiple times unnecessarily.An issue left to fix is support for the
--projectoption in schematic commands. Currently,getProjectNamedoes not know about this option, sincecreateWorkflowdoes not know how to parse the command line arguments. The parsing logic is implemented partially by the concrete implementation of theSchematicCommandtemplate method.