NgModule pattern blueprints prepared for RC5#1473
Closed
jkuri wants to merge 1 commit into
Closed
Conversation
ae476cc to
190dba1
Compare
Contributor
Author
|
Big thanks to @hansl spec tests now updated & passing. |
| this.project.initializeAddons(); | ||
| } | ||
|
|
||
| if (rawArgs[0] === 'component') { |
Contributor
There was a problem hiding this comment.
This should be directive as well, I think.
74da4d9 to
66f93e7
Compare
| import { CommonModule } from '@angular/common'; | ||
| import { FormsModule } from '@angular/forms'; | ||
| import { AppComponent } from './app.component'; | ||
| <% if (isMobile) { %> |
Contributor
There was a problem hiding this comment.
Put this on the previous line.
Contributor
Author
|
Closing in favor of #1579. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.