Skip to content

fix(@angular/cli): --verbose is an unknown option of serve #12367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansl merged 1 commit into from
Sep 26, 2018
Merged

fix(@angular/cli): --verbose is an unknown option of serve #12367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/angular_devkit/build_angular/src/dev-server/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ export interface DevServerBuilderOptions {
baseHref?: string;
progress?: boolean;
poll?: number;
verbose?: boolean;
}


Expand Down Expand Up @@ -407,6 +408,7 @@ export class DevServerBuilder implements Builder<DevServerBuilderOptions> {
...(options.baseHref !== undefined ? { baseHref: options.baseHref } : {}),
...(options.progress !== undefined ? { progress: options.progress } : {}),
...(options.poll !== undefined ? { poll: options.poll } : {}),
...(options.verbose !== undefined ? { verbose: options.verbose } : {}),
};

const browserTargetSpec = { project, target, configuration, overrides };
Expand Down
5 changes: 5 additions & 0 deletions packages/angular_devkit/build_angular/src/dev-server/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@
"default": false,
"alias": "o"
},
"verbose": {
"type": "boolean",
"description": "Adds more details to output logging.",
"default": false
},
"liveReload": {
"type": "boolean",
"description": "Whether to reload the page on change, using live-reload.",
Expand Down
12 changes: 11 additions & 1 deletion packages/angular_devkit/build_angular/test/dev-server/works_spec_large.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@
* found in the LICENSE file at https://angular.io/license
*/

import { request, runTargetSpec } from '@angular-devkit/architect/testing';
import { TestLogger, request, runTargetSpec } from '@angular-devkit/architect/testing';
import { from } from 'rxjs';
import { concatMap, take, tap } from 'rxjs/operators';
import { DevServerBuilderOptions } from '../../src';
import { devServerTargetSpec, host } from '../utils';


Expand All @@ -24,4 +25,13 @@ describe('Dev Server Builder', () => {
take(1),
).toPromise().then(done, done.fail);
}, 30000);

it('works with verbose', (done) => {
const overrides: Partial<DevServerBuilderOptions> = { verbose: true };
const logger = new TestLogger('verbose-serve');
runTargetSpec(host, devServerTargetSpec, overrides, undefined, logger).pipe(
tap(() => expect(logger.includes('Built at')).toBe(true)),
take(1),
).toPromise().then(done, done.fail);
}, 30000);
});