Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ccd6d8d
Choose a base ref
...
head repository: angular/angular-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b2f7a03
Choose a head ref
  • 5 commits
  • 8 files changed
  • 1 contributor

Commits on May 4, 2026

  1. fix(@angular/build): use dynamic TestComponentRenderer for Vitest 

    This commit implements a custom TestComponentRenderer in the virtual init-testbed.js file generated for Vitest. In Vitests non-isolated mode (isolate: false) with JSDOM, Vitest creates a fresh document for each spec file but reuses the module cache. The default Angular DOMTestComponentRenderer caches the document during initialization, leading to stale references and errors like setAttribute is not a function in subsequent tests. The new DynamicDOMTestComponentRenderer looks up the document dynamically on every operation, resolving the issue without requiring a breaking change to defaults or affecting browser-based testing.
    @clydin
    clydin committed May 4, 2026
    Configuration menu
    Copy the full SHA
    edfa782 View commit details
    Browse the repository at this point in the history

  2. fix(@schematics/angular): defer karma config deletion in Karma to Vit… 

    …est migration

This commit resolves a race condition in the Karma-to-Vitest migration where shared configuration files were deleted prematurely within the schematic transaction. Previously, the routine erased the target file upon discovering it was identical to boilerplate, which blinded other referring projects to extraction metadata.

The solution introduces analysis object caching so AST parsing occurs exactly once per discrete path. Deletion operations are deferred and batch-executed at the end of workspace processing. This mechanism guarantees continuous readability across iterating dependencies and yields operational speed improvements via memoized checks.
    @clydin
    clydin committed May 4, 2026
    Configuration menu
    Copy the full SHA
    aed407d View commit details
    Browse the repository at this point in the history

  3. refactor(@schematics/angular): support parsing plain template literal… 

    …s in karma config analyzer

Updates the AST analyzer to accept static backtick strings that do not contain runtime expressions. Previously, even simple template literals resulted in a fallback warning flag, triggering manual migration overrides unnecessarily.
    @clydin
    clydin committed May 4, 2026
    Configuration menu
    Copy the full SHA
    0d1f298 View commit details
    Browse the repository at this point in the history

  4. feat(@schematics/angular): update TSConfig globals during karma to vi… 

    …test migration

Automates the transition of developer test configurations from Jasmine typing providers to Vitest globals definitions.

The tool parses each collected tsconfig path and actively relocates 'vitest/globals' into the compiler options type list while removing the 'jasmine' package.
    @clydin
    clydin committed May 4, 2026
    Configuration menu
    Copy the full SHA
    8d0805d View commit details
    Browse the repository at this point in the history

  5. feat(@schematics/angular): conditionally install istanbul coverage pr… 

    …ovider for Vitest migration

Recognize non-Chromium browser usage during the Karma to Vitest migration. While Node-based and Chromium environments can leverage @vitest/coverage-v8, browser-based test runs using engines such as Firefox or WebKit natively necessitate istanbul instrumentation.
    @clydin
    clydin committed May 4, 2026
    Configuration menu
    Copy the full SHA
    b2f7a03 View commit details
    Browse the repository at this point in the history
Loading