feat(build): check circular depencies in Node.js#980
Conversation
7c3e107 to
021ae67
Compare
|
And it failed as expected, printing out the circular dependencies: |
|
@Mlaval This seems to be working, but I am not sure how it should be used. When I run |
|
@vsavkin the So my guess is that you ran the task with some old code in this folder, hence you got the list. Then, when you ran |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Introduces a new step in the build process which checks for circular dependencies to avoid issues in Node, as we saw in #931.
In fact, the check is done after removing all
import * as ...since they are safe there.It relies on madge in which support of ES6 modules has been added: pahen/madge#53.
The travis build is expected to fail here :)