Skip to content

docs(developer): add developer docs and refactor README#946

Closed
chalin wants to merge 1 commit into
angular:masterfrom
chalin:chalin-0312-devdoc
Closed

docs(developer): add developer docs and refactor README#946
chalin wants to merge 1 commit into
angular:masterfrom
chalin:chalin-0312-devdoc

Conversation

@chalin

@chalin chalin commented Mar 13, 2015

Copy link
Copy Markdown
Contributor

A first edition of DEVELOPER.md inspired from the angular.dart version, the angular.js documentation, and expanded to include instructions given in this repos’ README.md (which has been cleaned up and padded up).

Comment thread DEVELOPER.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make it clear that it is optional

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the download page that is being linked on line 27 is inclusive. I.e., it also provides a link to dev channel versions (via the archive page):

Want another Dart version? Use the download archive. It lets you choose specific versions of the Dart downloads. It also has the latest dev channel builds, which let you try new features a few weeks earlier than the stable channel.

And the interface provided by the archive page is much nicer than gsdview.appspot -- see below. I would avoid adding the extra link here. Agreed?


image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I was not aware about this. I always have troubles finding the dev versions which is why I have a bookmark on gsdview but your link is much better!

@mhevery

mhevery commented Mar 13, 2015

Copy link
Copy Markdown
Contributor

Love it! Thanks for helping others to get up to speed!

@mhevery mhevery added @lgtm action: merge The PR is ready for merge by the caretaker action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Mar 13, 2015
@chalin chalin force-pushed the chalin-0312-devdoc branch 2 times, most recently from 6e97a1b to f87cc35 Compare March 13, 2015 21:25
@chalin

chalin commented Mar 13, 2015

Copy link
Copy Markdown
Contributor Author

Ok then, anything else to be done or can this be merged? (Build is failing but I can't imagine it is due to my commit.)

A first edition of `DEVELOPER.md` inspired from the angular.dart version
and expanded to include instructions given in this repos’ `README.md`
(which has been cleaned up and padded up).
@chalin chalin force-pushed the chalin-0312-devdoc branch from 4cb3dd3 to eef81ba Compare March 18, 2015 01:49
@chalin

chalin commented Mar 18, 2015

Copy link
Copy Markdown
Contributor Author

Since the question came up again (in #982), I added an explicit mention of the stable and dev streams being available from the download archive.

@mhevery mhevery closed this in 28aa746 Mar 18, 2015
@chalin chalin deleted the chalin-0312-devdoc branch March 18, 2015 04:49
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants