Skip to content

Compile cli fix#8366

Closed
tbosch wants to merge 2 commits into
angular:masterfrom
tbosch:compile_cli_fix
Closed

Compile cli fix#8366
tbosch wants to merge 2 commits into
angular:masterfrom
tbosch:compile_cli_fix

Conversation

@tbosch
Copy link
Copy Markdown
Contributor

@tbosch tbosch commented May 1, 2016

No description provided.

tbosch added 2 commits April 30, 2016 18:46
Before, we would create all fields in the generated views
with visibility `private`. This does not work if an embedded
view references a directive / element in a parent view.
In Dart, this was no problem so far as it does not have
a `private` modifier.

Before, `useValue` in a provider did not work when doing
offline compile, as so far the `MetadataResolver` was only
used for jit mode. Now, `useValue` supports any kind of value
that the static reflector can return. E.g. primitives,
arrays, string maps, …
@tbosch tbosch force-pushed the compile_cli_fix branch from adc48b3 to e097c61 Compare May 1, 2016 01:46
return reflector.importUri(type);
}

// Only fill CompileIdentifierMetadata.runtime if needed...
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this comment

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels May 1, 2016
@mary-poppins
Copy link
Copy Markdown

Merging PR #8366 on behalf of @mprobst to branch presubmit-mprobst-pr-8366.

@alexeagle
Copy link
Copy Markdown
Contributor

LGTM thanks

@tbosch tbosch deleted the compile_cli_fix branch May 1, 2016 04:58
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants