Skip to content

fix(static reflector): Use only relative/absolute paths as module IDs.#8228

Closed
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:fix8225
Closed

fix(static reflector): Use only relative/absolute paths as module IDs.#8228
alexeagle wants to merge 1 commit into
angular:masterfrom
alexeagle:fix8225

Conversation

@alexeagle
Copy link
Copy Markdown
Contributor

The filename contains the module name as resolved by users.

Fixes #8225

The filename contains the module name as resolved by users.

Fixes angular#8225
@alexeagle alexeagle added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 26, 2016
@alexeagle
Copy link
Copy Markdown
Contributor Author

This has the downside that a third-party component would publish metadata with relative paths to angular2 that work only in their filesystem layout.

Discussed with @tbosch, both of us reached the conclusion that no resolution should occur across modules, and no symbol de-aliasing either.
Instead we should syntactically capture all the module's import statements, and leave references to other modules unresolved. The reader of the metadata is responsible for having a module resolver configured to resolve all of these.
Will work on another PR that does this.

@alexeagle
Copy link
Copy Markdown
Contributor Author

going with #8256 instead

@alexeagle alexeagle closed this Apr 26, 2016
@alexeagle alexeagle deleted the fix8225 branch April 26, 2016 20:07
@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metadata.json contains the name of the current module

3 participants