Repository navigation
Conversation
…r tsconfig globs When a tsconfig has no `exclude`, TypeScript skips `outDir` and `declarationDir` while expanding `include` globs. ng-analyze didn't, so emitted `.d.ts` and `.js` files inside the project could be picked up as sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a tsconfig has no
exclude(including throughextends), TypeScript skipsoutDiranddeclarationDirwhile expandingincludeglobs. ng-analyze didn't, so emitted.d.tsand.jsfiles inside the project could get picked up as sources.This only adds the output directories when
excludeis absent, same as TypeScript. oxc already resolves both options relative to the config that sets them, so the comparison is a path prefix check. An explicitexcludeis left alone.