Skip to content

fix(forms): resync select when option text changes #71444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auraseb wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −0
Open

fix(forms): resync select when option text changes #71444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/forms/signals/src/directive/select.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ function isRelevantSelectMutation(mutation: MutationRecord) {
if (mutation.target instanceof Comment) {
return false;
}
// A text node's data changed, which may change the implicit value of an `<option>`.
if (mutation.type === 'characterData') {
return true;
}
// Otherwise if any non-comment nodes were added / removed it is relevant.
for (const node of mutation.addedNodes) {
if (!(node instanceof Comment)) {
Expand Down
28 changes: 28 additions & 0 deletions packages/forms/signals/test/web/form_field.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4862,6 +4862,34 @@ describe('field directive', () => {
expect(fix.componentInstance.select()!.nativeElement.value).toEqual('four');
});

it('should resync the select value when the text of an option without a value changes', async () => {
@Component({
imports: [FormField],
template: `
<select #select [formField]="f">
<option>one</option>
<option>{{ label() }}</option>
</select>
`,
})
class TestCmp {
f = form(signal('two'));
select = viewChild<ElementRef<HTMLSelectElement>>('select');
label = signal('pending');
}

const fix = act(() => TestBed.createComponent(TestCmp));
await fix.whenStable();
const cmp = fix.componentInstance as TestCmp;

expect(cmp.select()!.nativeElement.value).toEqual('');

act(() => cmp.label.set('two'));
await fix.whenStable();

expect(cmp.select()!.nativeElement.value).toEqual('two');
});

it('initializes a required value input before the component lifecycle runs', () => {
let initialValue: string | undefined = undefined;
@Component({
Expand Down
Loading