Repository navigation
Conversation
Calling `abort()` without a reason creates a new `AbortError` with a stack trace on every call, which adds up when many resources are destroyed at once. Fixes angular#71422
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
ResourceImplkeeps itsAbortControllerafter a load resolves and callsabort()with no reason when the resource is destroyed. Without a reason, every call creates a newAbortErrorDOMExceptionand captures a stack trace, which gets expensive deep inside the view destroy recursion when a page with many resources is torn down.Issue Number: #71422
What is the new behavior?
Loads are aborted with one shared
AbortError, created lazily the first time it is needed. Loaders that forward the signal (for example tofetch) still see anAbortErroras the reason.Does this PR introduce a breaking change?