Repository navigation
Conversation
When a later frame has a directive that the first selected frame doesn't, `mergeFrames` added that frame's directive object to the merged result by reference. Merging the next frame then added its timings into the recorded frame, so selecting three or more frames inflated the stored change detection and lifecycle times, and they grew each time the range was selected again. Copy the directive before adding it to the merged result. Tested by adding a spec that merges three frames and checks that the input frames are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a later frame has a directive that the first selected frame doesn't,
mergeFramesadded that frame's directive object to the merged result by reference. Merging the next frame then added its timings into the recorded frame, so selecting three or more frames inflated the stored change detection and lifecycle times, and they grew each time the range was selected again.Copy the directive before adding it to the merged result.
Tested by adding a spec that merges three frames and checks that the input frames are unchanged.