Use actual directive def'n instead of mock.#706
Closed
kegluneq wants to merge 1 commit into
Closed
Conversation
Contributor
|
Please format your SHAs per https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format |
Contributor
There was a problem hiding this comment.
An actual component will never have variable length parameters, as it is not compatible with DI.
fce55f6 to
69e403a
Compare
… mock. In the transformer unit tests, we previously used a mock directive annotation. This update substitutes the actual Angular2 directive annotations.
69e403a to
8ba06af
Compare
Author
|
I believe I've addressed all comments - PTAL. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per earlier request & TODO in angular2/test/transform/common.dart