fix(core): detect static text hydration mismatches - #70215
Open
splincode wants to merge 1 commit into
Open
Conversation
Validate static text content in addition to node type so injected DOM with the same element shape cannot silently shift hydration claims. Report expected and actual content in NG0500 to identify the exact location of the mismatch. Refs angular#56392
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Hydration validates text nodes by node type only. A third-party script or browser extension can insert same-shaped DOM with different static text and shift hydration claims without producing a mismatch error.
Issue Number: #56392
What is the new behavior?
Hydration also validates non-empty static text content in development mode. When the DOM text differs from the template, Angular reports NG0500 with the expected and actual content and points to the mismatched location.
Does this PR introduce a breaking change?
Other information
No documentation update is needed because this change does not introduce or modify a public API.
Tested with:
pnpm bazel test //packages/platform-server/test:test --test_arg=--seed=15039