Skip to content

fix(language-service): account for strictTemplates being enabled by default #69906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisbeto wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Open

fix(language-service): account for strictTemplates being enabled by default #69906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/language-service/src/language_service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ export class LanguageService {
project.readFile(path),
);

if (!this.options.strictTemplates) {
if (this.options.strictTemplates === false) {
diagnostics.push({
messageText:
'Some language features are not available. ' +
Expand Down
16 changes: 14 additions & 2 deletions packages/language-service/test/legacy/language_service_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,11 @@ describe('language service adapter', () => {
});

describe('compiler options diagnostics', () => {
it('suggests turning on strict flag', () => {
it('suggests turning on strict flag when strictTemplates is explicitly false', () => {
configFileFs.overwriteConfigFile(TSCONFIG, {
angularCompilerOptions: {},
angularCompilerOptions: {
strictTemplates: false,
},
});
const diags = ngLS.getCompilerOptionsDiagnostics();
const diag = diags.find(isSuggestStrictTemplatesDiag);
Expand All @@ -128,6 +130,16 @@ describe('language service adapter', () => {
const diag = diags.find(isSuggestStrictTemplatesDiag);
expect(diag).toBeUndefined();
});

it('does not suggest turning on strict mode is strictTemplates flag is ommitted', () => {
configFileFs.overwriteConfigFile(TSCONFIG, {
angularCompilerOptions: {},
});
const diags = ngLS.getCompilerOptionsDiagnostics();
const diag = diags.find(isSuggestStrictTemplatesDiag);
expect(diag).toBeUndefined();
});

function isSuggestStrictTemplatesDiag(diag: ts.Diagnostic) {
return diag.code === ngErrorCode(ErrorCode.SUGGEST_STRICT_TEMPLATES);
}
Expand Down
Loading