fix(docs-infra): fix chevron visibility in aria examples in brave browser#69783
fix(docs-infra): fix chevron visibility in aria examples in brave browser#69783kalisaNkevin wants to merge 1 commit into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Your commit header's scope is wrong see https://github.com/angular/angular/blob/main/contributing-docs%2Fcommit-message-guidelines.md |
erkamyaman
left a comment
There was a problem hiding this comment.
And you should also squash your commits into one commit with the right commit header and body
|
Deployed adev-preview for 385a3da to: https://ng-dev-previews-fw--pr-angular-angular-69783-adev-prev-5zvtun0d.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
That doesn't look like to fix the issue. |
9e057c4 to
7dd219f
Compare
|
Before After |
7dd219f to
dfd322c
Compare
Ensure consistent alignment of tree items by always rendering the expand-icon placeholder. Leaf nodes display the placeholder invisibly using visibility: hidden, maintaining proper spacing that aligns with parent nodes. This fixes the visual inconsistency where leaf nodes appeared misaligned compared to parent nodes due to the missing chevron placeholder.
dfd322c to
385a3da
Compare
|
Actually we're hitting a chromium rendering bug here. I don't reproduce the chevron issue on other browsers |
|
I used brave browser to reproduce the bug rendering. But in other browser has no chevron issue @JeanMeche |
Brave Browser has its own issues, we use PrimeNG in where I work, from time to time, we get some weird css and html issues that only appear in Brave browser, then sometimes they disappear, also try to update your browser |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The ARIA tree basic example renders an empty chevron span for leaf nodes (files), causing visual misalignment in the tree view. The expand-icon was being rendered conditionally via text content binding instead of being conditionally rendered.
Issue Number: N/A
What is the new behavior?
The chevron icon is now only rendered for tree nodes that have children (expandable items). Leaf nodes no longer have the empty expand-icon span, resulting in proper alignment across all tree items.
Does this PR introduce a breaking change?
Other information
This is a documentation example improvement. The fix useslow to conditionally render the expand-icon span only whenthe node has children, improving the visual presentation of the ARIA tree example.
Key points about this PR:
Ready to commit whenever you are!