refactor(core): use native Promise.withResolvers() in tests#69739
Draft
MeAkib wants to merge 1 commit into
Draft
refactor(core): use native Promise.withResolvers() in tests#69739MeAkib wants to merge 1 commit into
Promise.withResolvers() in tests#69739MeAkib wants to merge 1 commit into
Conversation
Member
|
We cannot use |
JeanMeche
requested changes
Jul 11, 2026
JeanMeche
left a comment
Member
There was a problem hiding this comment.
Please only replace it in the test files.
Replaces the temporary `promiseWithResolvers` polyfill with the native `Promise.withResolvers()` API in test files and Updates the TypeScript configuration to include the `es2024.promise`.
70f2a94 to
ec3ede4
Compare
Promise.withResolvers()Promise.withResolvers() in tests
JeanMeche
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #69686 (comment)
Replaces the temporary
promiseWithResolverspolyfill with the nativePromise.withResolvers()API now that it is supported by both the runtime and TypeScript.Also removes the polyfill and its exports, and updates the TypeScript configuration to include the
es2024library.