fix(core): warn when overrideComponent is called with layout/imports/schema overrides in AOT mode#69730
Open
clydin wants to merge 1 commit into
Open
fix(core): warn when overrideComponent is called with layout/imports/schema overrides in AOT mode#69730clydin wants to merge 1 commit into
clydin wants to merge 1 commit into
Conversation
476ced6 to
6800b62
Compare
dgp1130
reviewed
Jul 10, 2026
| ); | ||
| }); | ||
|
|
||
| it('should NOT warn when overrideComponent is called on an AOT component with safe overrides (like providers)', () => { |
Contributor
There was a problem hiding this comment.
Consider: Should we also test not warning on a JIT component?
| console.warn( | ||
| `[Angular] WARNING: 'TestBed.overrideComponent' was called on '${component.name}' with template/import/schema overrides in AOT mode. ` + | ||
| `This is not fully supported and may cause NG0304/NG0303 element resolution errors. \n` + | ||
| `👉 Workaround: Disable AOT compilation in the build configuration used for tests (e.g. set 'aot: false' or equivalent).`, |
Contributor
There was a problem hiding this comment.
Consider: Should we point out @Component({jit: true}) as an option? You probably don't want that for production components, but might be useful for test components without opting-out the whole test suite into JIT? Maybe this is too easy to misuse to be worth calling out, but figured I'd mention it?
Contributor
There was a problem hiding this comment.
Perhaps we could also create an entry in the documentation for this case?
dgp1130
approved these changes
Jul 10, 2026
…schema overrides in AOT mode TestBed.overrideComponent relies on runtime decorator metadata to dynamically recompile components. When tests are compiled in AOT mode, decorator metadata is compiled away, meaning template or imports overrides can fail silently or cause confusing NG0304/NG0303 errors. To improve developer experience, this adds a runtime warning when TestBed.overrideComponent is called on an AOT-compiled component with template, import, schema, or layout overrides in AOT mode. A warning is printed to the console suggesting to disable AOT (aot: false) in the test build configuration as a workaround. Overriding provider/viewProvider metadata remains fully supported without warnings.
6800b62 to
0de2838
Compare
Member
|
Unless |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBed.overrideComponent relies on runtime decorator metadata to dynamically recompile components. When tests are compiled in AOT mode, decorator metadata is compiled away, meaning template or imports overrides can fail silently or cause confusing NG0304/NG0303 errors.
To improve developer experience, this adds a runtime warning when TestBed.overrideComponent is called on an AOT-compiled component with template, import, schema, or layout overrides in AOT mode. A warning is printed to the console suggesting to disable AOT (aot: false) in the test build configuration as a workaround.
Overriding provider/viewProvider metadata remains fully supported without warnings.