fix(core): allow static attributes for explicit input transforms#69729
fix(core): allow static attributes for explicit input transforms#69729JeanMeche wants to merge 1 commit into
Conversation
This is a follow-up to angular#67997, which allowed explicit read generics with input transforms, such as `input<boolean>(false, {transform: booleanAttribute})`. That fixed the declaration, but static template attributes like `dismissible="true"` and bare `dismissible` were still checked as strings against the read type. Allow the fallback write type to include static attribute strings so these template forms compile.
|
cc @cexbrayat, this is actually breaking. ex: |
|
Hmm, this approach might not work then. Unless we widen the type for FCV to Or maybe this should be abandoned and fixed at the TCB level, but that would require someone with better understanding of the TCB than me I'm afraid. |
|
This is something I did look into with #66562, |
|
Isn't #67997 just undesirable in the first place; the return type If the return type is changed to |
This is a follow-up to #67997, which allowed explicit read generics with input transforms, such as
input<boolean>(false, {transform: booleanAttribute}).That fixed the declaration, but static template attributes like
dismissible="true"and baredismissiblewere still checked as strings against the read type. Allow the fallback write type to include static attribute strings so these template forms compile.Trying to re-land #69427