fix(core): allow static attributes for explicit input transforms#69427
Open
cexbrayat wants to merge 1 commit into
Open
fix(core): allow static attributes for explicit input transforms#69427cexbrayat wants to merge 1 commit into
cexbrayat wants to merge 1 commit into
Conversation
This is a follow-up to angular#67997, which allowed explicit read generics with input transforms, such as `input<boolean>(false, {transform: booleanAttribute})`. That fixed the declaration, but static template attributes like `dismissible="true"` and bare `dismissible` were still checked as strings against the read type. Allow the fallback write type to include static attribute strings so these template forms compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
This is a follow-up to #67997, which allowed explicit read generics with input transforms, such as
input<boolean>(false, {transform: booleanAttribute}).That fixed the declaration, but static template attributes like
dismissible="true"and baredismissiblewere still checked as strings against the read type.What is the new behavior?
Allow the fallback write type to include static attribute strings so these template forms compile.
Does this PR introduce a breaking change?
Other information