fix(compiler): parsing of an empty template literal interpolation#69706
Open
hawkgs wants to merge 2 commits into
Open
fix(compiler): parsing of an empty template literal interpolation#69706hawkgs wants to merge 2 commits into
hawkgs wants to merge 2 commits into
Conversation
Even if we have an `EmptyExpr`, add that expression to the expressions array when a literal is parsed. The lack of the expression results in a discrepancy in the sizes of the `elements` and the `expressions` arrays of a `TemplateLiteral`, that result in an error when we visit that same literal due to the missing expression. Fixes angular#69699
Ensure that empty template literal interpolation is handled gracefully.
crisbeto
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor fix.
Even if we have an
EmptyExpr, add that expression to the expressions array when a literal is parsed. The lack of the expression results in a discrepancy in the sizes of theelementsand theexpressionsarrays of aTemplateLiteral, that leads to an error when we visit that same literal due to the missing expression.Fixes #69699
Additionally, I've added a test to the language service, just in case, that ensures the scenario is handled gracefully.