Skip to content

fix(localize): build runtime translations map with a null prototype #69705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshsmith1 wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −2
Open

fix(localize): build runtime translations map with a null prototype #69705

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/localize/src/translate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ export function loadTranslations(translations: Record<MessageId, TargetMessage>)
$localize.translate = translate;
}
if (!$localize.TRANSLATIONS) {
$localize.TRANSLATIONS = {};
// Keyed by message ID, which is taken verbatim from the `translations` map (e.g. parsed from a
// translation file), so it can be `__proto__`. Indexing a plain object with that key assigns
// through the inherited `__proto__` setter, reparenting the map instead of storing the entry
// (and throwing under `--disable-proto=throw`). A null-prototype map makes it an ordinary key.
$localize.TRANSLATIONS = Object.create(null);
}
Object.keys(translations).forEach((key) => {
$localize.TRANSLATIONS[key] = parseTranslation(translations[key]);
Expand All @@ -86,7 +90,7 @@ export function loadTranslations(translations: Record<MessageId, TargetMessage>)
*/
export function clearTranslations() {
$localize.translate = undefined;
$localize.TRANSLATIONS = {};
$localize.TRANSLATIONS = Object.create(null);
}

/**
Expand Down
21 changes: 21 additions & 0 deletions packages/localize/test/translate_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,27 @@ describe('$localize tag with translations', () => {
);
});
});

describe('with a `__proto__` message id', () => {
afterEach(() => {
clearTranslations();
});

it('should treat `__proto__` as an ordinary translation key', () => {
loadTranslations({
['__proto__' as MessageId]: 'pwned' as TargetMessage,
[computeMsgId('abc', '')]: 'abc' as TargetMessage,
});

const store = ($localize as unknown as {TRANSLATIONS: Record<string, unknown>}).TRANSLATIONS;
// The malicious id must be stored as an own key rather than assigned through the inherited
// `__proto__` setter, which would reparent the map (and drop the entry).
expect(Object.getPrototypeOf(store)).toBe(null);
expect(Object.prototype.hasOwnProperty.call(store, '__proto__')).toBe(true);
// A translation loaded alongside it still resolves.
expect($localize`abc`).toEqual('abc');
});
});
});

function computeIds(
Expand Down
Loading