docs: show ng-add schema files in schematics-for-libraries guide#69691
Open
franmc01 wants to merge 1 commit into
Open
docs: show ng-add schema files in schematics-for-libraries guide#69691franmc01 wants to merge 1 commit into
franmc01 wants to merge 1 commit into
Conversation
The ng-add walkthrough references two files it never shows: the collection points to `ng-add/schema.json` and `index.ts` imports its `Schema` interface from `ng-add/schema.ts`. Add the missing code blocks, mirroring the generation-support section, so the example is complete. Fixes angular#57005
|
Deployed adev-preview for 06344cf to: https://ng-dev-previews-fw--pr-angular-angular-69691-adev-prev-ajrqwoma.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
In the "Schematics for libraries" guide, the
ng addwalkthrough references two files it never shows: the collection (collection.1.json) points tong-add/schema.json, andng-add/index.tsimports itsSchemainterface fromng-add/schema.ts. A reader following the walkthrough hits both references with no definition.Issue Number: #57005
What is the new behavior?
ng-add/schema.jsonandng-add/schema.ts, mirroring the "Providing generation support" section that already shows the equivalent files formy-service.<docs-code>blocks. No prose rewrite and no example-code changes.Does this PR introduce a breaking change?
Other information
Fixes #57005