fix(localize): use Object.hasOwn for placeholder lookup in translate#69664
Open
arshsmith1 wants to merge 1 commit into
Open
fix(localize): use Object.hasOwn for placeholder lookup in translate#69664arshsmith1 wants to merge 1 commit into
arshsmith1 wants to merge 1 commit into
Conversation
JeanMeche
approved these changes
Jul 8, 2026
Member
|
Can you please have a look at the linting error. Thank you. |
`translate()` looked up substitutions with `message.substitutions.hasOwnProperty(placeholder)`. A message whose placeholder is named `hasOwnProperty` stores that key on the plain substitutions object, shadowing the method, so the lookup calls the substitution value and throws a TypeError. Use `Object.hasOwn` instead, which resolves through `Object` and is unaffected by the shadowed key, matching the recent `I18nSelectPipe` fix.
36aad3a to
eb9a9f9
Compare
Contributor
Author
|
Good catch, the commit only had a subject line. Added a body describing the fix so it clears the min-length check. Pushed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issue Number: N/A
translate()callsmessage.substitutions.hasOwnProperty(placeholder)to decide whether a translation placeholder has a matching substitution. A message whose placeholder is legitimately namedhasOwnPropertystores that key on the plainsubstitutionsobject built byparseMessage, which shadows the method, so the lookup calls the substitution value instead of the method and throwsTypeError: message.substitutions.hasOwnProperty is not a function.What is the new behavior?
The lookup uses
Object.hasOwn(message.substitutions, placeholder), which resolves throughObjectand is unaffected by a shadowed key or a null-prototype object, so the placeholder resolves normally. This is the same swap made recently forI18nSelectPipe. Added a regression test that throws before the change and passes after.Does this PR introduce a breaking change?
Other information