fix(vscode-extension): Support inlay hint in inline templates#69657
Open
JeanMeche wants to merge 1 commit into
Open
fix(vscode-extension): Support inlay hint in inline templates#69657JeanMeche wants to merge 1 commit into
JeanMeche wants to merge 1 commit into
Conversation
Contributor
|
Thx for the fix @JeanMeche! it('should return an Angular-specific inlay hint for inline template', async () => {
// 1. open APP_COMPONENT (or a fixture with e.g. an @for loop var)
// 2. send lsp.InlayHintRequest.type for APP_COMPONENT_URI, full range
// 3. assert response is non-null/non-empty
// 4. assert label matches the expected hint
});
it('should return an Angular-specific inlay hint for external template', async () => {
// same as above but against FOO_TEMPLATE / FOO_TEMPLATE_URI
});using This should guard before situaltions like the one being fixed here. |
48fd812 to
a8c88d8
Compare
We were explicitly not supporting them with an early return. fixes angular#69649
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were explicitly not supporting them with an early return.
fixes #69649