fix(compiler): use regular optional chaining expression for safe function calls in TCBs#69621
Open
JeanMeche wants to merge 1 commit into
Open
fix(compiler): use regular optional chaining expression for safe function calls in TCBs#69621JeanMeche wants to merge 1 commit into
JeanMeche wants to merge 1 commit into
Conversation
1e81c65 to
85d1dae
Compare
JeanMeche
commented
Jul 2, 2026
| appFile.moveCursorToText('something?.va¦lue()'); | ||
| const info = appFile.getQuickInfoAtPosition()!; | ||
| expect(toText(info.displayParts)).toEqual('(property) value: Signal<number>'); | ||
| expect(toText(info.displayParts)).toEqual('(property) value: () => number'); |
Member
Author
There was a problem hiding this comment.
This is what the TSLS reports.
JoostK
approved these changes
Jul 3, 2026
JoostK
left a comment
Member
There was a problem hiding this comment.
LGTM assuming this survives a TGP
…tion calls in TCBs Optional return types should not report non-nullable optional chaning on function calls. fixes angular#69609
85d1dae to
dce022b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should not report non-nullable optional chaning on function calls.
fixes #69609