-
Notifications
You must be signed in to change notification settings - Fork 27.3k
fix(forms): warn in dev mode when ngModel cannot reach parent NgForm across component boundary #69585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arturovt
wants to merge
1
commit into
angular:main
Choose a base branch
from
arturovt:fix/forms_47580
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(forms): warn in dev mode when ngModel cannot reach parent NgForm across component boundary #69585
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # NgModel in child component cannot reach parent form | ||
|
|
||
| This warning is emitted when `ngModel` (or any template-driven form control) is placed inside | ||
| a child component whose parent component hosts a form directive (`NgForm` or | ||
| `FormGroupDirective`), but the control cannot register with that form. | ||
|
|
||
| The root cause is that `NgModel` injects `ControlContainer` with `@Host()`, which stops the | ||
| injector from crossing component boundaries. The form directive in the parent component's | ||
| template is invisible to `NgModel` in the child's template. | ||
|
|
||
| As a result, the child's controls silently act as standalone — they do not participate in the | ||
| parent form's value, validity, or submission state. | ||
|
|
||
| ## Fixing the warning | ||
|
|
||
| ### Option 1: bridge the `ControlContainer` with `viewProviders` | ||
|
|
||
| Add `viewProviders` to the child component so it re-exports the parent form into its own view. | ||
| Use the same class that the warning names — `NgForm` for template-driven forms (`<form>`), or | ||
| `FormGroupDirective` for reactive forms (`[formGroup]`): | ||
|
|
||
| ```typescript | ||
| // Parent uses a template-driven form: <form> ... <app-child> </form> | ||
| import {ControlContainer, NgForm} from '@angular/forms'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-child', | ||
| template: `<input name="email" [(ngModel)]="email" />`, | ||
| viewProviders: [{provide: ControlContainer, useExisting: NgForm}], | ||
| }) | ||
| export class Child { | ||
| email = ''; | ||
| } | ||
| ``` | ||
|
|
||
| ```typescript | ||
| // Parent uses a reactive form: <div [formGroup]="myGroup"> ... <app-child> </div> | ||
| import {ControlContainer, FormGroupDirective} from '@angular/forms'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-child', | ||
| template: `<input name="email" [(ngModel)]="email" />`, | ||
| viewProviders: [{provide: ControlContainer, useExisting: FormGroupDirective}], | ||
| }) | ||
| export class Child { | ||
| email = ''; | ||
| } | ||
| ``` | ||
|
|
||
| The parent form then sees and validates the child's controls normally. | ||
|
|
||
| ### Option 2: mark the control as standalone | ||
|
|
||
| If the child's controls should genuinely be independent of the parent form, opt out explicitly: | ||
|
|
||
| ```html | ||
| <input name="email" [(ngModel)]="email" [ngModelOptions]="{standalone: true}" /> | ||
| ``` | ||
|
|
||
| ## Debugging the warning | ||
|
|
||
| The warning message includes the error code `NG01354`. Use the call stack to locate which | ||
| `ngModel` triggered it. Check whether the component that owns the `<form>` tag is the same | ||
| component that owns the `ngModel` input — if they differ, apply one of the options above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if we don't have a
NgFormas parent but aFormGroup?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid concert, updated the code.