Skip to content

fix(core): reject dynamic script host elements#69551

Merged
alxhub merged 1 commit into
angular:mainfrom
SkyZeroZx:fix-script-host-element
Jul 1, 2026
Merged

fix(core): reject dynamic script host elements#69551
alxhub merged 1 commit into
angular:mainfrom
SkyZeroZx:fix-script-host-element

Conversation

@SkyZeroZx

Copy link
Copy Markdown
Contributor

The previous fix for GHSA-692r-grfm-v8x7 was incomplete because it rejected script tags only when locating an explicit host element. Dynamic component instantiation can also infer the host element from the component selector.

Move the script-host rejection to the point where ComponentFactory has resolved the host element for either path, so createComponent rejects script hosts consistently.

The previous fix for GHSA-692r-grfm-v8x7 was incomplete because it rejected script tags only when locating an explicit host element. Dynamic component instantiation can also infer the host element from the component selector.

Move the script-host rejection to the point where ComponentFactory has resolved the host element for either path, so createComponent rejects script hosts consistently.
@pullapprove pullapprove Bot requested a review from atscott June 28, 2026 05:21
@angular-robot angular-robot Bot added the area: core Issues related to the framework runtime label Jun 28, 2026
@ngbot ngbot Bot added this to the Backlog milestone Jun 28, 2026
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Jun 29, 2026
@alan-agius4 alan-agius4 requested review from JeanMeche and removed request for atscott June 29, 2026 07:32
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jun 29, 2026
@alxhub alxhub merged commit d7f7061 into angular:main Jul 1, 2026
30 checks passed
@alxhub

alxhub commented Jul 1, 2026

Copy link
Copy Markdown
Member

This PR was merged into the repository. The changes were merged into the following branches:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants