fix(docs-infra): align and highlight external-link icon in nav sidebar#69497
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): align and highlight external-link icon in nav sidebar#69497erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
The open_in_new icon on external navigation items stayed grey on hover and sat inset from the chevron column, so it never matched the chevron items visually. - Add a hover rule so the icon brightens to --primary-contrast along with the label, matching the chevron/text behaviour. - Override the 1rem max-width reserve inherited from .docs-faceted-list-item-text by chaining both classes the span carries (.docs-external-link.docs-faceted-list-item-text), so the icon lines up with the chevrons at the link's end-padding. Using :host was avoided because it breaks the nested `a:hover &` selector.
69ddf1d to
c42b3d1
Compare
Contributor
Author
|
I had to change the commit header, could you please rerun the preview tests? So sorry 🙏 @JeanMeche |
|
Deployed adev-preview for c42b3d1 to: https://ng-dev-previews-fw--pr-angular-angular-69497-adev-prev-zaurbufa.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The open_in_new icon on external navigation items stayed grey on hover and sat inset from the chevron column, so it never matched the chevron items visually.
a:hover &selector.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On external navigation items in the docs sidebar, the
open_in_newicon stayed grey on hover (while the label brightened) and sat inset from the chevron column, so external items did not align with the chevron items above them.What is the new behavior?
The external-link icon now brightens to
--primary-contraston hover along with its label, and its right edge aligns with the chevron column at the link's end-padding.Does this PR introduce a breaking change?