refactor(core): cleanup Meta service#69487
Open
JeanMeche wants to merge 1 commit into
Open
Conversation
SkyZeroZx
reviewed
Jun 23, 2026
| constructor(@Inject(DOCUMENT) private _doc: any) { | ||
| this._dom = getDOM(); | ||
| } | ||
| private readonly _doc = inject(DOCUMENT); |
Contributor
There was a problem hiding this comment.
Q: Should this also apply to Title since it is similar, or only for the moment to Meta?
Member
Author
There was a problem hiding this comment.
Yeah, I'll need to check first if that doesn't break g3 (because it will require an injection context)
Contributor
There was a problem hiding this comment.
IIRC, when I tried both back then, we had some breaks within G3.
583e317 to
cbc8644
Compare
Contributor
|
@JeanMeche you have a typo in the commit message. |
Member
Author
The service had a rather old implementation. This is mostly a cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The service had a rather old implementation. This is mostly a cleanup.