refactor(compiler): Move the attribute comment to the HTML AST#69463
Open
JeanMeche wants to merge 1 commit into
Open
refactor(compiler): Move the attribute comment to the HTML AST#69463JeanMeche wants to merge 1 commit into
JeanMeche wants to merge 1 commit into
Conversation
91fdbe8 to
4ee28de
Compare
crisbeto
reviewed
Jun 22, 2026
| } | ||
| } | ||
|
|
||
| export class AttributeComment implements BaseNode { |
Member
There was a problem hiding this comment.
AttributeComment sounds a bit like the comment is inside an attribute. Maybe something like ElementStartComment or StartTagComment?
Member
Author
There was a problem hiding this comment.
You're right, let's go with StartTagComment
4ee28de to
396f474
Compare
SkyZeroZx
reviewed
Jun 22, 2026
396f474 to
3f6b3c6
Compare
This is to help the support for comment formating by third-party tools like prettier.
3f6b3c6 to
052d27f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to help the support for comment formating by third-party tools like prettier.