fix(compiler-cli): apply debugName transform to required signal queries#69462
Open
P4 wants to merge 1 commit into
Open
fix(compiler-cli): apply debugName transform to required signal queries#69462P4 wants to merge 1 commit into
P4 wants to merge 1 commit into
Conversation
Transform assumed `.required` functions always take options as the first argument. This is true for `input` and `model`, but not for `viewChild` and `contentChild`, which take the same arguments as non-required versions. Change the code to put options for signal queries in the right position, causing debugName to be correctly generated for signal queries.
JeanMeche
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transform assumed
.requiredfunctions always take options as the first argument. This is true forinputandmodel, but not forviewChildandcontentChild, which take the same arguments as non-required versions.Change the code to put options for signal queries in the right position, causing debugName to be correctly generated for signal queries.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
the transform is only applied for plain versions of signal queries,
.requiredare left without adebugName:The transform tries to do the same thing as for
input/model.required, i.e. place the debug name as the first argument. Since the locator argument is not an object literal, the transform does nothing.What is the new behavior?
required versions are transformed the same way as the plain versions.
changing options position for
.requiredis done only forinputandmodel.Does this PR introduce a breaking change?
Other information