fix(compiler-cli): include toSignal in debugName transform#69461
Open
P4 wants to merge 2 commits into
Open
Conversation
the toSignal function received a debugName option in 0812ac3, but was not covered by the signalMetadataTransform which sets the debugName in dev mode automatically.
JeanMeche
approved these changes
Jun 22, 2026
JeanMeche
reviewed
Jun 22, 2026
| import {of} from 'rxjs'; | ||
| declare function toSignal(source: any): any; | ||
|
|
||
| @Component({ |
Member
There was a problem hiding this comment.
Several tests a missing an import for Component.
Contributor
Author
There was a problem hiding this comment.
my bad, these tests originally used toSignal in a variable declaration, I rewrote them last minute because that code wouldn't work at runtime (toSignal needs injection context), even though it compiles and gets transformed correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the toSignal function received a debugName option in 0812ac3, but was not covered by the signalMetadataTransform which sets the debugName in dev mode automatically.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
when running under
ng serve, toSignal does not have thedebugNameset automatically like the other functions (signal, computed, httpResource, etc.)What is the new behavior?
toSignal gets the same treatment as other functions with
debugName:is transformed into
which adds a
debugNamein dev mode, and gets optimized away in prod mode.Does this PR introduce a breaking change?
Other information