fix(core): avoid uncaught promise errors in injectAsync prefetching#69460
Open
crisbeto wants to merge 1 commit into
Open
fix(core): avoid uncaught promise errors in injectAsync prefetching#69460crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
Fixes a minor issue where the `preload` function in `injectAsync` might cause an uncaught promise error. I also fixed that in `onIdle` we were passing the wrong function into `assertInInjectionContext`.
JeanMeche
approved these changes
Jun 22, 2026
atscott
reviewed
Jun 22, 2026
| options | ||
| .prefetch() | ||
| .then(() => load()) | ||
| .catch(() => {}); |
Contributor
There was a problem hiding this comment.
Should errors go to the error handler?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue where the
preloadfunction ininjectAsyncmight cause an uncaught promise error.I also fixed that in
onIdlewe were passing the wrong function intoassertInInjectionContext.