fix(compiler): account for NgModule dependencies in JIT-compiled part…#69454
Open
JoostK wants to merge 1 commit into
Open
fix(compiler): account for NgModule dependencies in JIT-compiled part…#69454JoostK wants to merge 1 commit into
JoostK wants to merge 1 commit into
Conversation
…ial declarations When partial declarations are not preprocessed to AOT by the linker, the `ngDeclareComponent` call causes them to be compiled ad-hoc. In this mode, NgModule imports in standalone components would be dropped, deviating from the linker. This commit changes the ad-hoc compilation of component declarations to pass the NgModule imports along just like the linker does. Fixes angular#69451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ial declarations
When partial declarations are not preprocessed to AOT by the linker, the
ngDeclareComponentcall causes them to be compiled ad-hoc. In this mode, NgModule imports in standalone components would be dropped, deviating from the linker. This commit changes the ad-hoc compilation of component declarations to pass the NgModule imports along just like the linker does.Fixes #69451