feat(forms): add signal forms support for custom elements#69452
Open
kyubisation wants to merge 1 commit into
Open
feat(forms): add signal forms support for custom elements#69452kyubisation wants to merge 1 commit into
kyubisation wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69232
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently when using Form Signals with custom elements that implement form association, Angular does not respect the corresponding capabilities, which result in values being read incorrectly or form attributes not being applied, even though they might be applicable.
Issue Number: #69232
What is the new behavior?
Angular now checks whether a given element is a form associated custom element and depending on use case, verifies the capabilities of the custom element (e.g. support for
min/max, etc.).Depending on the custom elementy
typeproperty, Angular now also checks whether the value should be read fromvalue,valueAsNumberorvalueAsDate.Does this PR introduce a breaking change?
Other information