fix(compiler-cli): report diagnostic instead of crashing on malformed… - #69441
Merged
Conversation
crisbeto
reviewed
Jun 19, 2026
atscott
reviewed
Jun 19, 2026
… host binding `parseHostBindings` throws plain `Error`s for malformed host bindings (e.g. a property binding with a non-static value, as can happen while editing in the language service). These were uncaught during directive analysis, crashing the compiler and the Angular Language Service. Wrap the call and surface the error as a `FatalDiagnosticError` so it becomes a diagnostic and analysis can complete normally. Fixes angular#69106
aparzi
force-pushed
the
fix-angular-language-service-69106
branch
from
June 23, 2026 12:43
deb5ce7 to
e376ee7
Compare
atscott
approved these changes
Jun 23, 2026
JeanMeche
approved these changes
Jun 24, 2026
Contributor
2 tasks
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseHostBindingsthrows plainErrors for malformed host bindings (e.g. a property binding with a non-static value, as can happen while editing in the language service). These were uncaught during directive analysis, crashing the compiler and the Angular Language Service.Wrap the call and surface the error as a
FatalDiagnosticErrorso it becomes a diagnostic and analysis can complete normally.Fixes #69106
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Issue Number: #69106
Does this PR introduce a breaking change?