Skip to content

fix(forms): prevent stale CVA writeback during debounce #69436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BHUVANSH855 wants to merge 2 commits into
base: main
Choose a base branch
from
+66 −3
Open

fix(forms): prevent stale CVA writeback during debounce #69436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49c0547
fix(forms): prevent stale CVA writeback during debounce
BHUVANSH855 Jun 19, 2026
9b008ad
test(forms): register writeback test control as CVA
BHUVANSH855 Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/forms/signals/src/directive/control_cva.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,12 @@ export function cvaControlCreate(

return () => {
const fieldState = parent.state();
const value = fieldState.value();
const controlValue = fieldState.controlValue();

if (bindingUpdated(bindings, 'controlValue', value)) {
if (bindingUpdated(bindings, 'controlValue', controlValue)) {
// We don't know if the interop control has underlying signals, so we must use `untracked` to
// prevent writing to a signal in a reactive context.
untracked(() => parent.controlValueAccessor!.writeValue(value));
untracked(() => parent.controlValueAccessor!.writeValue(controlValue));
}

for (const name of CONTROL_BINDING_NAMES) {
Expand Down
63 changes: 63 additions & 0 deletions packages/forms/signals/test/web/interop.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,69 @@ describe('ControlValueAccessor', () => {
expect(field().value()).toBe('initial');
});

it('should not write stale model values back to a CVA while debounce is pending', () => {
let writeValues: string[] = [];

@Component({
selector: 'custom-control-writeback-test',
template: `<input [value]="value" (input)="onInput($event.target.value)" />`,
providers: [
{
provide: NG_VALUE_ACCESSOR,
useExisting: CustomControlWritebackTest,
multi: true,
},
],
})
class CustomControlWritebackTest implements ControlValueAccessor {
value = '';

private onChangeFn?: (value: string) => void;

writeValue(newValue: string): void {
writeValues.push(newValue);
this.value = newValue;
}

registerOnChange(fn: (value: string) => void): void {
this.onChangeFn = fn;
}

registerOnTouched(fn: () => void): void {}

onInput(newValue: string) {
this.value = newValue;
this.onChangeFn?.(newValue);
}
}

@Component({
imports: [CustomControlWritebackTest, FormField],
template: `<custom-control-writeback-test [formField]="f" />`,
})
class TestCmp {
readonly f = form(signal('initial'), (p) => {
debounce(p, 'blur');
});
}

const fixture = act(() => TestBed.createComponent(TestCmp));

const debugEl = fixture.debugElement.query(
(el) => el.componentInstance instanceof CustomControlWritebackTest,
);

const cvaInstance = debugEl.componentInstance as CustomControlWritebackTest;

writeValues = [];

act(() => cvaInstance.onInput('updated'));

expect(cvaInstance.value).toBe('updated');

expect(writeValues).toEqual([]);
});

describe('properties', () => {
describe('disabled', () => {
it('should bind to directive input', () => {
Expand Down
Loading