fix(docs-infra): improve Retro clear button visibility in dark mode#69428
Open
BHUVANSH855 wants to merge 1 commit into
Open
fix(docs-infra): improve Retro clear button visibility in dark mode#69428BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
Replace the clear button color token in Retro autocomplete examples to improve contrast and visibility in dark mode. Also add the missing win95-dark-gray token and update hover styling for consistent behavior across Retro variants.#
JeanMeche
requested changes
Jun 18, 2026
| font-family: 'Press Start 2P'; | ||
|
|
||
| --retro-button-color: #fff; | ||
| --win95-dark-gray: #4a4a4a; |
Member
There was a problem hiding this comment.
That variable, if named as such is misplaced.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review @JeanMeche
I introduced --win95-dark-gray locally to improve the clear button contrast, but I noticed the Retro tree examples already define a Win95 token set that includes --win95-dark-gray with a different value.
Would you prefer that I align the autocomplete example with the existing Win95 token definitions, or use a more locally scoped variable for the clear button styling?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
In the Retro theme variants of the ARIA Autocomplete examples, the clear ("X") button uses
--win95-shadowas its text color. This can result in poor contrast and reduced visibility, particularly in dark mode.Issue Number: N/A
What is the new behavior?
Replaces
--win95-shadowwith--win95-dark-grayfor the clear button text color.Adds a
--win95-dark-graytoken to the Retro theme scope.Updates the hover state to maintain consistent icon contrast.
Applies the change consistently across:
basic/retrohighlight/retromanual/retroThis improves visibility of the clear button while preserving the Retro theme appearance.
Does this PR introduce a breaking change?
Other information
This is a visual accessibility fix only. No Autocomplete functionality or behavior has been changed.