refactor(devtools): restructure profiler and directive forest code#69396
Open
hawkgs wants to merge 1 commit into
Open
refactor(devtools): restructure profiler and directive forest code#69396hawkgs wants to merge 1 commit into
hawkgs wants to merge 1 commit into
Conversation
- Rename `DirectiveForestHooks` to `DirectiveForestManager` - Keep profiler reference standalone; move it out from `DirectiveForestHooks`/`DirectiveForestManager` - Convert profiler-specific `IdentityTracker` behavior to a more generalized one - Separate timing API functionality from the `DirectiveForestHooks`/`DirectiveForestManager` initialization fn - Reorganize files; rename `/hooks` to `/profiling` - Use concrete types for directive and component instances (incomplete coverage; based on `any` at the moment) - Other more minor changes
997a18f to
c240370
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR focuses on separating the profiler functionality from the directive forest hooks (i.e. some separation of concerns) in order to make it more easily manageable and extensible. On top of that, the
DirectiveForestHookswas renamed toDirectiveForestManagersince its main role in the app is to provide the indexed forest for our client events.List of all changes:
DirectiveForestHookstoDirectiveForestManagerDirectiveForestHooks/DirectiveForestManagerIdentityTrackerbehavior to a more generalized oneDirectiveForestHooks/DirectiveForestManagerinitialization fn/hooksto/profilinganyat the moment)