refactor(core): update signalGraphTool to accept an Injector#69366
Open
csmick wants to merge 1 commit into
Open
refactor(core): update signalGraphTool to accept an Injector#69366csmick wants to merge 1 commit into
csmick wants to merge 1 commit into
Conversation
Refactor the AI debugging signalGraphTool to accept an Injector instance (named `injector`) rather than an HTMLElement. Requiring an Injector directly simplifies the tool's execution validation and decouples it from DOM element discovery utilities, allowing callers (including tests and DevTools) to resolve and pass the appropriate Injector directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the AI debugging signalGraphTool to accept an Injector instance (named
injector) rather than an HTMLElement. Requiring an Injector directly simplifies the tool's execution validation and decouples it from DOM element discovery utilities, allowing callers (including tests and DevTools) to resolve and pass the appropriate Injector directly.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
signalGraphToolaccepts the root DOM Element of the component for which it will return the signal graph.Issue Number: N/A
What is the new behavior?
The
signalGraphToolaccepts the Injector of the component for which it will return the signal graph.Does this PR introduce a breaking change?
Other information