fix(core): prevent unsubscribe during emit from throwing off other listeners#69327
Open
crisbeto wants to merge 1 commit into
Open
fix(core): prevent unsubscribe during emit from throwing off other listeners#69327crisbeto wants to merge 1 commit into
crisbeto wants to merge 1 commit into
Conversation
…steners Fixes that when a listener unsubscribes from an `output` within its own callback, it was preventing subsequent listeners from running. These changes fix the issue by not mutating the array while the emit loop is running, but replacing the listener with `null` and coming back later to remove it. Fixes angular#69325.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that when a listener unsubscribes from an
outputwithin its own callback, it was preventing subsequent listeners from running.These changes fix the issue by not mutating the array while the emit loop is running, but replacing the listener with
nulland coming back later to remove it.Fixes #69325.