fix(service-worker): validate redirected hashed asset responses#69209
Open
claudeloba wants to merge 1 commit into
Open
fix(service-worker): validate redirected hashed asset responses#69209claudeloba wants to merge 1 commit into
claudeloba wants to merge 1 commit into
Conversation
Carry the expected asset hash through redirected network fetches so a hashed manifest entry cannot cache bytes from a different redirect target.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry the expected asset hash through redirected network fetches so a hashed manifest entry cannot cache bytes from a different redirect target.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When a hashed service-worker asset request is fulfilled through a redirect, the final redirected response can be returned to the caching path without validating the final response body against the original manifest hash.
Issue Number: N/A
What is the new behavior?
The expected manifest hash is carried through redirected network fetches. If the final successful redirected response body does not match the original hash, Angular raises a service-worker critical error instead of returning the mismatched response for caching.
Does this PR introduce a breaking change?
Other information
Tested with:
bazelisk test //packages/service-worker/worker/test:test --test_output=errors --cache_test_results=nogit diff --check main..HEADpnpm ng-dev commit-message validate-range main HEADpnpm ng-dev format changed --check mainpnpm tslintpnpm ts-circular-deps:check