fix(docs-infra): load cross-origin video embeds under COEP credential…#69205
Open
erkamyaman wants to merge 1 commit into
Open
fix(docs-infra): load cross-origin video embeds under COEP credential…#69205erkamyaman wants to merge 1 commit into
erkamyaman wants to merge 1 commit into
Conversation
…less adev is cross-origin isolated (COOP same-origin + COEP require-corp) so the embedded WebContainer editor can use SharedArrayBuffer. Under require-corp the cross-origin YouTube iframe in `<docs-video>` only loaded in Chromium, leaving the player blank in Safari. Switch COEP from `require-corp` to `credentialless`. The page stays cross-origin isolated, so the editor keeps working, but cross-origin frames are now allowed to load, which restores the inline player in Safari as well.
Contributor
Author
|
Thanks for the pointer in #55310 (comment) this was exactly it @JeanMeche Relaxing the embedder policy to One gap remains: Firefox still blocks the embed, since it has no What do you think of this approach? I know it's a bit ugly but better than firefox error screen. Happy to adjust if you'd rather handle it differently. Screen.Recording.2026-06-06.at.11.27.41.movFirefox is sadly still the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adev is cross-origin isolated (COOP same-origin + COEP require-corp) so the embedded WebContainer editor can use SharedArrayBuffer. Under require-corp the cross-origin YouTube iframe in
<docs-video>only loaded in Chromium, leaving the player blank in Safari.Switch COEP from
require-corptocredentialless. The page stays cross-origin isolated, so the editor keeps working, but cross-origin frames are now allowed to load, which restores the inline player in Safari as well.PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
adev sets
COOP: same-origin+COEP: require-corpon every response so theembedded WebContainer editor can use
SharedArrayBuffer. Underrequire-corp,the cross-origin YouTube iframe in
<docs-video>only loads in Chromium (viathe
credentiallessiframe attribute). In Safari the player is blank.What is the new behavior?
Switches COEP from
require-corptocredentiallessinadev/angular.jsonandadev/firebase.json. The page stays cross-origin isolated (the editor keepsworking), but cross-origin frames are now allowed to load, which fixes the
inline player in Safari as well as Chromium.
Does this PR introduce a breaking change?